Workaround 'SetModTime: 450' also for FTP?

sYbb12 · March 30, 2022, 3:08pm

hi guys, I have exactly that problem mentioned here:

I also know that the files are actually copied fine, but my backend system relies on the error code returned by rclone. In this situation (getting more and more daily), rclone always returns an error, so my backend thinks: "Oh shit, files are not copied, alert!!"

Can I make this ignore somehow, so that the result code is a success again? The solution mentioned here just works for SFTP, but not for FTP (I tried):

Thanks, Stefan

ncw · March 31, 2022, 3:52pm

Do you want to send a patch for this line of code?

github.com

rclone/rclone/blob/6ea26b508a41ced220892f5ceb732a99d29e2be7/backend/ftp/ftp.go#L1029

      
        
            			}
            			o.fs.putFtpConnection(&c, err)
            		}
            	}
            	return o.info.ModTime
            }
            
            
// SetModTime sets the modification time of the object
            func (o *Object) SetModTime(ctx context.Context, modTime time.Time) error {
            	if !o.fs.fSetTime {
            		fs.Errorf(o.fs, "SetModTime is not supported")
            		return nil
            	}
            	c, err := o.fs.getFtpConnection(ctx)
            	if err != nil {
            		return err
            	}
            	path := path.Join(o.fs.root, o.remote)
            	path = o.fs.opt.Enc.FromStandardPath(path)
            	err = c.SetTime(path, modTime.In(time.UTC))
            	if err == nil && o.info != nil {

It needs to be fs.Debugf rather than fs.Errorf to be a bit less noisy.

Link to this forum message in the commit message.

sYbb12 · March 31, 2022, 4:15pm

Would this change also result in another error code? And sorry, cannot send a patch or something, I am not a developer

ncw · March 31, 2022, 9:41pm

It would stop that error message being printed in the log.

That error message doesn't cause a non zero return code - if you've got that it is a different cause and the end of the log will say why.

system · May 31, 2022, 5:42pm

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.