Very very minor issue with Makefile

Dev Discussions
1

This has no real impact; just means locally built dev instance may have an odd looking ID number :slight_smile:

In the Makefile you have

... git show --no-patch --no-notes --pretty='%h' HEAD

This is meant to get the ID of the current commit, so it shows up in the build version number.

However older versions of git (eg 1.8.3, which is what RedHat 7.9 comes with) doesn't support the --no-patch option, so that line throws an error (it doesn't stop the build)

The result is something like

% ./rclone version | head -1
rclone v1.60.0-beta.6375.

For compatibility with older git CLIs maybe git rev-parse HEAD | cut -c-9 .

Now we get the full rclone v1.60.0-beta.6375.72227a015 version number!

As I said, a very very minor issue :slight_smile:

2

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.