Unable to follow setup instructions in contributing guidelines

Hi, I recently was preparing an rclone pull request and ran into an issue with the instructions in CONTRIBUTING.md for checking out the source code.

go get -u github.com/rclone/rclone
cd $GOPATH/src/github.com/rclone/rclone

The go get command apparently downloaded a bunch of modules in $GOPATH but there was no src directory containing the repository. I ended up manually cloning the repository to the expected path and proceeding from there.

As a complete Go newbie I'm not sure how to fix the instructions. Possibly relevant: cmd/go: no way to `go get` source code for editing in module mode · Issue #31529 · golang/go · GitHub

I was using go 1.16.3 from the golang:latest docker image.

I think these instructions need to be updated for go1.16 as the default for the GO111MODULE is on now.

I think the instructions should probably say this now-a-days

git clone https://github.com/rclone/rclone
go build

I just looked t the website and that is pretty much what they do say in the installing from source section: Install

So I think we need to update the instructions in contributing

Do you want to send a PR to fix?

Sure, here it is: contributing.md: update setup instructions for go1.16 by nickgaya · Pull Request #5206 · rclone/rclone · GitHub

1 Like

Thank you - and merged :slight_smile:

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.