SIGUSR2 message in log

drwtsn32 · September 25, 2024, 6:49pm

Sending SIGUSR2 to toggle the bandwidth limiter always shows this in the log, regardless of it being toggled off or back on:

2024/09/25 14:38:50 NOTICE: Bandwidth limit disabled by user

I think it should show the current bandwidth limit when being toggled back on.

I believe this is just a reporting issue in the log. The bandwidth limiter DOES seem to be toggled back on correctly.

rclone v1.68.1
- os/version: ubuntu 20.04 (64 bit)
- os/kernel: 5.4.0-196-generic (x86_64)
- os/type: linux
- os/arch: amd64
- go/version: go1.23.1
- go/linking: static
- go/tags: none

asdffdsa · September 25, 2024, 7:06pm

hi,
is this a bug or are you requesting a new feature?

drwtsn32 · September 25, 2024, 7:33pm

Bug. I think it should display the "disabled by user" message only when toggling the bwlimit OFF.

When toggling it back ON, it should not say "disabled by user" but should show the current bwlimit, like it does other times in the log. Example:

2024/09/25 13:27:30 INFO  : Starting bandwidth limiter at 95Mi:off Byte/s

drwtsn32 · September 25, 2024, 8:30pm

I'm sorry but how is this not a bug?

When bwlimit is toggled back on (by sending subsequent SIGUSR2), the message put in the log file is that the limit is disabled. That's clearly wrong.

Maybe I'm not explaining this very well.

asdffdsa · September 25, 2024, 8:32pm

ok, now i understand.

drwtsn32 · September 25, 2024, 8:35pm

Looks like it's supposed to say "Bandwidth limit enabled by user" when toggling back on:

github.com

rclone/rclone/blob/master/fs/accounting/accounting_unix.go#L36-L43


      
          				tb.toggledOff = !tb.toggledOff
          				tb.curr, tb.prev = tb.prev, tb.curr
          				s := "disabled"
          				if !tb.curr._isOff() {
          					s = "enabled"
          				}
          
          				fs.Logf(nil, "Bandwidth limit %s by user", s)

Not sure why that's not working properly.

asdffdsa · September 25, 2024, 8:38pm

ok, might want to open an issue at github

drwtsn32 · September 25, 2024, 9:07pm

done....

github.com/rclone/rclone

SIGUSR2 notification in log always says bandwidht limit is "disabled" even when toggling back on

opened 09:06PM - 25 Sep 24 UTC

drwtsn32x

Sending SIGUSR2 to toggle the bandwidth limiter always shows "disabled" in the l…og, regardless of it being toggled off or back on: ``` 2024/09/25 14:38:50 NOTICE: Bandwidth limit disabled by user ``` I believe this is just a reporting issue in the log. The bandwidth limiter DOES seem to be toggled back on correctly. According to the source, it looks like it should say "enabled" when toggling the bandwidth limiter back on (with a subsequent SIGUSR2): https://github.com/rclone/rclone/blob/master/fs/accounting/accounting_unix.go#L36-L43 ``` tb.toggledOff = !tb.toggledOff tb.curr, tb.prev = tb.prev, tb.curr s := "disabled" if !tb.curr._isOff() { s = "enabled" } fs.Logf(nil, "Bandwidth limit %s by user", s) ``` Version info: ``` rclone v1.68.1 - os/version: ubuntu 20.04 (64 bit) - os/kernel: 5.4.0-196-generic (x86_64) - os/type: linux - os/arch: amd64 - go/version: go1.23.1 - go/linking: static - go/tags: none ```

asdffdsa · September 25, 2024, 9:14pm

sorry, i guess i am still a bit confused.

are you also asking for a new feature?

drwtsn32 · September 27, 2024, 3:45pm

I said that before I looked at the source. I was speculating on what the message was supposed to say.

Issue has been fixed and the message has been enhanced.

system · September 30, 2024, 3:46pm

This topic was automatically closed 3 days after the last reply. New replies are no longer allowed.