Rclone check should respect --dry-run

Feature
1

rclone check does not seem to respect --dry-run.
based on the test below, rclone should not have checked the .txt files.
i would expect to see

DEBUG : 1.txt: Not checking as --dry-run

DEBUG : rclone: Version "v1.52.0" starting with parameters ["c:\\data\\rclone\\scripts\\rclone-v1.52.0.exe" "check" "C:\\test" "wasabieast2:testcheckdryrun" "--include=*.txt" "--dry-run" "--log-file=testcheckdryrun.log" "--log-level=DEBUG"]
DEBUG : fs cache: renaming cache item "C:\\test" to be canonical "//?/C:/test"
DEBUG : S3 bucket testcheckdryrun: Waiting for checks to finish
DEBUG : 2.zzz: Excluded
DEBUG : 2.zzz: Excluded
DEBUG : 1.txt: MD5 = d41d8cd98f00b204e9800998ecf8427e OK
DEBUG : 1.txt: OK
DEBUG : 2.txt: MD5 = d41d8cd98f00b204e9800998ecf8427e OK
DEBUG : 2.txt: OK
NOTICE: S3 bucket testcheckdryrun: 0 differences found
NOTICE: S3 bucket testcheckdryrun: 2 matching files
DEBUG : 5 go routines active
2

Checking isn't normally considered destructive. Why do you want to skip it?

3

i find that working with filters is complex and takes a few tests to get it correct.
when setting up a sync, and using filters, i can use --dry-run to make sure i got the filter flags correct.
but not with check, to make sure that the filter flags are correct.

check can take many,many hours to complete, given only one check can be done at a time.
so i need to know upfront that the check and filter flags are correct.
all the more so, when using --download

thanks

4

Can you please make a new issue on github about this and we'll fix in due course - thanks!

5

i created the issue.

thanks

1 Like
6

the beta seems to be working

  • respects --dry-run
  • respects --checkers

thanks

7

Thanks for testing!

I've merged this to master now which means it will be in the latest beta in 15-30 mins and released in v1.53

8

i will test and if problem i will let you know.
thanks

9

is it possible to upload the beta first and then annouce it after it has been compiled and uploaded?
thanks

10

It is possible but doing it this way means I don't have to wait for 20 mins to build and I can be getting on with other stuff. I do this maybe 10 times a day so it really makes a difference!

11

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.