Copyurl same file name overwrite

VladKappa · January 3, 2020, 10:42pm

What is the problem you are having with rclone?

When doing copyurl it automatically overwrites existing file on the remote without giving an error/warning.

What is your rclone version (output from `rclone version`)

1.50.2

Which OS you are using and how many bits (eg Windows 7, 64 bit)

W7 64

Which cloud storage system are you using? (eg Google Drive)

Nextcloud

The command you were trying to run (eg `rclone copy /tmp remote:tmp`)

rclone copyurl url.webm remote:/"filename.webm"

A log from the command with the `-vv` flag (eg output from `rclone -vv copy /tmp remote:tmp`)

N/A ?

Basically filename.webm already exist on the remote. I want to be warned about this when doing copyurl, is there a flag that does this or something that I am missing? I've been searching for a bit and couldn't find anything. Thanks in advance!

Edit: I am using a crypted remote, does it change anything?

ncw · January 4, 2020, 10:11am

I think that would need a new flag for copyurl.

Fancy having a go at that?

VladKappa · January 4, 2020, 10:19am

I am not sure what I'd need or what exactly would you want me to do as I'm so new to this awesome piece of software.

If you'd want me to test something I'm up for it! Thanks

Edit: I don't want autofilename, I want to set a custom file name and if the destination already has the exact same file name to warn me or throw an error. I couldn't seem to find how exactly to achieve that

ncw · January 4, 2020, 10:59am

I was just wondering if you were a software developer and you'd like to contribute a flag to the copyurl command.

I was thinking of a flag like --no-clobber which when specified made sure copyurl didn't overwrite an existing file.

How does that sound?

If you like the idea please please make a new issue on github

VladKappa · January 4, 2020, 11:03am

Oh, I'm a computer science student, not even a junior. I like the idea and I feel like it would be useful for copyurl.

If I'll figure it out I could probably start an issue and if I feel even luckier I could contribute by trying to implement it, without even knowing where to start.

Thanks, that's what I neeeed to know, I thinked there was already a feature that I was not seeing. Guess your answer will be the solution.

ncw · January 4, 2020, 1:25pm

Go is quite readable if you want to dive in and have a go!

Here is the source of the copyurl command: https://github.com/rclone/rclone/blob/master/cmd/copyurl/copyurl.go

You could add a new flag --no-clobber there and pass it on to operations.CopyURL

github.com

rclone/rclone/blob/7e6fac8b1eaeccbf48e197e2c1f12627c3e69ca5/fs/operations/operations.go#L1616


		if err != nil {
			fs.Errorf(dstFileName, "Post request rcat error: %v", err)


			return nil, err
		}
	}


	return obj, nil
}


// CopyURL copies the data from the url to (fdst, dstFileName)
func CopyURL(ctx context.Context, fdst fs.Fs, dstFileName string, url string, dstFileNameFromURL bool) (dst fs.Object, err error) {
	client := fshttp.NewClient(fs.Config)
	resp, err := client.Get(url)
	if err != nil {
		return nil, err
	}
	defer fs.CheckClose(resp.Body, &err)
	if resp.StatusCode < 200 || resp.StatusCode >= 300 {
		return nil, errors.Errorf("CopyURL failed: %s", resp.Status)
	}

In there you'd want to check to see if destination exists if the noClobber flag was set by calling fdst.NewObject(dstFileName) and if no error and and object was returned then return an error.

system · January 7, 2020, 1:26pm

This topic was automatically closed 3 days after the last reply. New replies are no longer allowed.